Conversation
Contributor
Author
|
Opened against upstream in error; this change belongs in our internal repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #2446
GitHub rejected reopening this closed PR. The verified, rebased implementation is now open at #2446. This closure was in error, not a withdrawal of the feature.
Summary
Replacement for #2197: the earlier closure was in error, not a withdrawal of the feature. GitHub rejected reopening the original PR after the refreshed branch was pushed, so this replacement carries the verified update. Rebased onto upstream
65f00ae119269113613a39028b7a935693b860e6, including the new active-alert banner.Verification
go test -tags 'testing no_ui' ./... -count=1 -timeout 180sgo test -race -tags 'testing no_ui' ./internal/alerts -run 'Test(SelectTemperature|Temperature|SystemAlertsCache)' -count=1 -timeout 180sbun testininternal/site: 29 tests, 114 assertions.bunx tsc --noEmitandbun run buildininternal/site.05c791bcc63571f4395182b55f8ebc5e0304d11dwithvcs.modified=false.Test environment note
The full normal Go suite and focused race suite use PocketBase's
no_uibuild tag to avoid an existing test-harness duplicate registration ofGET /_/extensions.jswhen reusing API scenarios. This does not replace UI testing: browser E2E used the normal production UI build withoutno_ui. The broader alerts race run detected a race inTestAlertSilencedWithActualAlertand exceeded its 180-second limit. The same race reproduces on pristine upstream65f00ae1withgo test -race -tags 'testing no_ui' ./internal/alerts -run '^TestAlertSilencedWithActualAlert$' -count=1 -timeout 90s; it is outside this feature diff. Feature-focused race tests pass. No production data, deployment changes, or private integration code are included.